search

zeitdice / zeitmachine-qt

Time Lapse Building App for the zeitdice
GNU General Public License v3.0
5 stars 4 forks source link

Default deflicker #72

Open mschwanzer opened 6 years ago

mschwanzer commented 6 years ago

ffmpeg can take -vf 'deflicker=s=6, atadenoise' to deflicker the video, can this be done on the fly rendering and be default, also for export?

simonrepp commented 6 years ago

Generally i suppose that the answer is yes for both, but as deflickering is performed as a function on a set of images i'm not sure this plays well with how the on the fly video output pipeline works. And in consequence it might be that because of ties that might exist between the on-the-fly and the final export pipeline it might be hard to implement it for only one of them. That would be my quick assessment without actually studying the code.

mschwanzer commented 6 years ago

deflicker would need ffmpeg 4 which I am not sure we should touch yet.

simonrepp commented 6 years ago

deflicker was actually added in 3.4 already :) (see http://ffmpeg.org/index.html#news)

If this is about stability, I don't think it's much of a concern, in my experience (and also how they see it - see quote below) ffmpeg major releases are more like regular snapshots, I have not seen any classical "version bump breaks things" stuff happening ever since we use ffmpeg, and it's been a while now. In fact I think the only reason this is even a major release is that they removed the ffserver, ffmenc and ffmdec binaries, which we totally don't compile anyway. :)

Approximately every 3 months the FFmpeg project makes a new major release. Between major releases point releases will appear that add important bug fixes but no new features. Note that these releases are intended for distributors and system integrators. Users that wish to compile from source themselves are strongly encouraged to consider using the development branch (see above), this is the only version on which FFmpeg developers actively work. The release branches only cherry pick selected changes from the development branch, which therefore receives much more and much faster bug fixes such as additional features and security patches.