zeitgeistpm / documentation

Source material for Zeitgeist's documentation site.
https://docs.zeitgeist.pm
3 stars 12 forks source link

Fix double logo and highlighting in navbar #55

Closed maltekliemann closed 2 years ago

maltekliemann commented 2 years ago

Currently, the Zeitgeist logo is displayed twice in the localized docs, and the highlighting of the chapters is broken. This PR fixes both.

Screenshot 2022-07-08 at 14 02 39
vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Jul 8, 2022 at 0:04AM (UTC)
saboonikhil commented 2 years ago

Is this fixed? This is what I see at my local:

Screenshot 2022-08-04 at 10 35 20 AM

However, Getting Started gets highlighted by default while navigating to Learn, Build or Monitor.

maltekliemann commented 2 years ago

@saboonikhil Yeah, looks good to me.

maltekliemann commented 2 years ago

Sorry, I misunderstood. You mean on the main branch, that's what it looks like? Try switching to the localized docs.

saboonikhil commented 2 years ago

Sorry, I misunderstood. You mean on the main branch, that's what it looks like? Try switching to the localized docs.

I am running docs on my local at localhost:3000. There's still highlighting issue with Getting Started

maltekliemann commented 2 years ago

@saboonikhil Thanks! Can you give exact steps for reproduction?

The only way I was able to recreate this problem was to click on the top-left Zeitgeist logo, which (confusingly) links to docs.zeitgeist.pm, which, of course, still runs the old version.

saboonikhil commented 2 years ago

@saboonikhil Thanks! Can you give exact steps for reproduction?

The only way I was able to recreate this problem was to click on the top-left Zeitgeist logo, which (confusingly) links to docs.zeitgeist.pm, which, of course, still runs the old version.

My bad, the code at this branch fixes the issue. Excellent!

maltekliemann commented 2 years ago

Thanks, mate!