search

zeitgeistpm / documentation

Source material for Zeitgeist's documentation site.
https://docs.zeitgeist.pm
3 stars 12 forks source link

fix i18n && add ukraine #58

Closed Whisker17 closed 1 year ago

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Aug 17, 2022 at 3:09PM (UTC)
Whisker17 commented 2 years ago

I've fixed the building bug, so it's able to merge after reviewing.

maltekliemann commented 2 years ago

@Whisker17 There are a lot of really strange reformats in this PR. I'll open a review to give some examples in a moment.

Whisker17 commented 2 years ago

@maltekliemann Fixed the syntax error, they told me to add 2 spaces at the end of the sentence, and it works. So what about the fmt problem?

maltekliemann commented 2 years ago

The translations look fine now. But the question still stands: Can't they just disable the reformatting completely?

Whisker17 commented 2 years ago

The translations look fine now. But the question still stands: Can't they just disable the reformatting completely?

I think all we need to do is add 2 spaces when we use ::: (in the source documentation, not translation). So I think it should be not a problem, what do you think of it?

maltekliemann commented 2 years ago

It's also the removal of the link abstractions. How were these changes applied? Manually, or using a formatter?

Whisker17 commented 2 years ago

It's also the removal of the link abstractions. How were these changes applied? Manually, or using a formatter?

Manually. Because Crowdin can't recognize such a linking method, so I changed the linking method.

maltekliemann commented 2 years ago

Manually. Because Crowdin can't recognize such a linking method, so I changed the linking method.

Ok, thanks. Do they have a list of things that we can't do?

maltekliemann commented 2 years ago

@Whisker17 Actually, now I'm really confused: i18n/ru/docusaurus-plugin-content-docs/current/getting-started.md

This file still has the link abstractions. If the way they're done there is ok, then it would be perfect if you handled all links in this fashion.

Whisker17 commented 2 years ago

@Whisker17 Actually, now I'm really confused: i18n/ru/docusaurus-plugin-content-docs/current/getting-started.md

This file still has the link abstractions. If the way they're done there is ok, then it would be perfect if you handled all links in this fashion.

I've tested it again, in docs/getting-started.md, everything goes well, and If we use the previous hyperlinking method in docs/learn/prediction-markets.md, there will be problems with their recognition in Crowdin, and the source file will also be modified. The following picture shows the translation file pulled from Crowdin if we use the previous linking method, which will not pass the compilation, and you can see it also modified markdown content.

image

maltekliemann commented 2 years ago

Thanks. So, I got three questions:

  1. I'm not quite sure I understand. If you write this (which is the method used in getting-started.md and different from the method used in prediction-markets.md):

    [Hayek][]
...

    Does that work with Crowdin?

  2. If not, then why does it work for some files but not others?

  3. Does Crowdin provide a list of markdown syntax that doesn't work?

maltekliemann commented 1 year ago

Closing (seems outdated)