zeitgeistpm / ui

Zeitgeist general prediction markets application.
https://app.zeitgeist.pm
Apache License 2.0
16 stars 4 forks source link

Incompatible account handling #1084

Open Robiquet opened 1 year ago

Robiquet commented 1 year ago

https://github.com/polkadot-js/extension/issues/1250

lsaether commented 1 year ago

@ltfschoen Can you provide us more info for this issue? Thanks!

ltfschoen commented 1 year ago

https://github.com/polkadot-js/extension/issues/1250#issuecomment-1510146933

https://github.com/polkadot-js/extension/issues/1250#issuecomment-1510140844

dapps need to filter based on chain type. so maybe have to filter Ethereum H160 addresses differently than for Substrate H256 addresses.

Robiquet commented 1 year ago

polkadot-js/extension#1250 (comment)

polkadot-js/extension#1250 (comment)

dapps need to filter based on chain type. so maybe have to filter Ethereum H160 addresses differently than for Substrate H256 addresses.

How did you create an Ethereum wallet in your polkadot js?

ltfschoen commented 1 year ago

i had a quick glance, maybe take a look here

https://github.com/zeitgeistpm/ui/blob/staging/lib/hooks/queries/useAccountAssetBalances.ts

https://github.com/zeitgeistpm/ui/blob/staging/lib/state/wallet.ts

https://github.com/polkadot-js/common/blob/master/packages/util-crypto/src/address/encode.ts

Robiquet commented 1 year ago

i had a quick glance, maybe take a look here

https://github.com/zeitgeistpm/ui/blob/staging/lib/hooks/queries/useAccountAssetBalances.ts

https://github.com/zeitgeistpm/ui/blob/staging/lib/state/wallet.ts

https://github.com/polkadot-js/common/blob/master/packages/util-crypto/src/address/encode.ts

Sorry I'm not following, I'm trying to reproduce the issue but I'm not sure how to create an Ethereum account in the Polkadot js wallet. Do you have any information on that?

ltfschoen commented 1 year ago

polkadot-js/extension#1250 (comment) polkadot-js/extension#1250 (comment) dapps need to filter based on chain type. so maybe have to filter Ethereum H160 addresses differently than for Substrate H256 addresses.

How did you create an Ethereum wallet in your polkadot js?

personally i don't create ethereum accounts using polkadot.js. try creating them using desktop software that creates Ethereum addresses on an air-gapped local machine. verify that your download of that desktop software hasn't been compromised

Robiquet commented 1 year ago

polkadot-js/extension#1250 (comment) polkadot-js/extension#1250 (comment) dapps need to filter based on chain type. so maybe have to filter Ethereum H160 addresses differently than for Substrate H256 addresses.

How did you create an Ethereum wallet in your polkadot js?

personally i don't create ethereum accounts using polkadot.js. try creating them using desktop software that creates Ethereum addresses on an air-gapped local machine. verify that your download of that desktop software hasn't been compromised

Is it possible to get some steps to reproduce the issue you were seeing?

ltfschoen commented 1 year ago

polkadot-js/extension#1250 (comment) polkadot-js/extension#1250 (comment) dapps need to filter based on chain type. so maybe have to filter Ethereum H160 addresses differently than for Substrate H256 addresses.

How did you create an Ethereum wallet in your polkadot js?

personally i don't create ethereum accounts using polkadot.js. try creating them using desktop software that creates Ethereum addresses on an air-gapped local machine. verify that your download of that desktop software hasn't been compromised

Is it possible to get some steps to reproduce the issue you were seeing?

all the steps are written at this link https://github.com/zeitgeistpm/ui/issues/1084#issue-1675196447