zeitungen / node-rpi-rgb-led-matrix

Project not maintained :( - Pilot your rgb led matrix with Nodejs ! Nodejs binding of rpi-rgb-led-matrix library https://github.com/hzeller/rpi-rgb-led-matrix
Do What The F*ck You Want To Public License
57 stars 48 forks source link

Fix a couple of compile errors and logical problems. #10

Closed hzeller closed 8 years ago

hzeller commented 8 years ago

o ledmatrix.cc: include unistd.h to be able to use usleep(). o ledmatrix.cc: Fix logical error when validating passed parameters. (!expr == 5) first negates expression, then compares with 5. What was meant was (expr != 5) o ledmatrix.cc: Fix comparison in assert() between signed int and unsigned size_t o image.{h,cc}: getters for colors were returning 'const uint8_t', which does not make much sense as the return value is always returned by value (and is ignored by the compiler). While at it, make the methods const, which is a useful trait. o Fix installation script that referred to 'node' instead of 'nodejs' o Add missing newlines at end of .h and .cc files (technically, a missing newline at the end of input is an invalid c file).

Fixes #9