Updated to use Nan and multiple versions of Node.js up to 5

zeitungen / node-rpi-rgb-led-matrix

Project not maintained :( - Pilot your rgb led matrix with Nodejs ! Nodejs binding of rpi-rgb-led-matrix library https://github.com/hzeller/rpi-rgb-led-matrix

Do What The F*ck You Want To Public License

57 stars 48 forks source link

Updated to use Nan and multiple versions of Node.js up to 5 #5

Closed sebleedelisle closed 8 years ago

sebleedelisle commented 8 years ago

Rewritten in the style recommended in https://github.com/nodejs/node-addon-examples for Nan (https://github.com/nodejs/nan) so should be good for versions 0.8, 0.10, 0.12, 4 and 5.

Tested on 5.4.1, needs testing on other versions.

zeitungen commented 8 years ago

Hello, Thanks for your work ! I'll try to get some time this weekend to test it with a nodejs 0.10.x and merge it !

sebleedelisle commented 8 years ago

My pleasure, hope it helps!

I had a bit of spare time (and a spare Raspberry Pi!) so I tried installing the module on node 0.10.29 and I'm getting the error in Nan that is outlined here : https://github.com/nodejs/nan/issues/414

Which is annoying. It seems like there's something wrong with the version of gyp-node that comes with npm 1.4.21. I'm trying to see if I can upgrade gyp-node now... I'll let you know how I get along.

Seb

sebleedelisle commented 8 years ago

Found a slight problem with it, I think I've fixed it, will make a new PR when I'm sure.