search

zeke / all-the-cities

🌆 All the 138,398 cities of the world with a population of at least 1000 inhabitants, in a big JSON array.
http://npm.im/all-the-cities
MIT License
281 stars 42 forks source link

Guangzhou population #8

Closed oprogramador closed 5 years ago

oprogramador commented 6 years ago

Guangzhou has about 14 millions inhabitants (http://worldpopulationreview.com/world-cities/guangzhou-population/). However according to this library, it's only 3152825 (above 3 millions).

zeke commented 6 years ago

Yeah the underlying cities1000 module is very out of date and the author no longer maintains it. It might be necessary to fork that module to bring this one up to date.

oprogramador commented 6 years ago

@zeke I forked cities1000 to https://github.com/oprogramador/cities1000 where I updated the Guangzhou population.

nabilashraf commented 5 years ago

@zeke I believe this issue is resolved with the addition of latest data in cities1000

zeke commented 5 years ago

Nice!

oprogramador commented 3 years ago

Currently, I find the following (for all-the-cities@3.1.0):

{
  cityId: 1809858,
  name: 'Guangzhou',
  altName: '',
  country: 'CN',
  featureCode: 'PPLA',
  adminCode: '30',
  population: 11071424,
  loc: { type: 'Point', coordinates: [ 113.25, 23.11667 ] }
}

and:

{
  cityId: 8595889,
  name: 'Guangzhoulu',
  altName: '',
  country: 'CN',
  featureCode: 'PPLA3',
  adminCode: '15',
  population: 0,
  loc: { type: 'Point', coordinates: [ 102.16809, 38.49915 ] }
}
oprogramador commented 3 years ago

So now for Guangzhou, I get about 11M which is closer to the real data.

zeke commented 3 years ago

Hi @oprogramador. So what needs to happen? Another update to cities1000?

oprogramador commented 3 years ago

@zeke

Now it's better than previously but if you want, you can update cities1000.

According to https://worldpopulationreview.com/world-cities/guangzhou-population, it's 13.6M as of 2021.