zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning

https://github.com/apps/semantic-pull-requests

Apache License 2.0

1.24k stars 122 forks source link

rfc: consider not using console methods #101

Closed cdaringe closed 2 years ago

cdaringe commented 4 years ago

problem

https://github.com/zeke/semantic-pull-requests/blob/a1d743d558e012952f4d3ab395137487b32afe6e/lib/is-semantic-message.js#L14 usage bypasses my expressed intent when configuring probot logger

discussion

if anything log.debug(...), as this type of failure is expected, and thus we don't need to log expected behavior expect when we are tracing/debugging.

zeke commented 4 years ago

@cdaringe I'm open to changing this. Would you care to open a pull request making this change?

zeke commented 2 years ago

This issue is old and inactive so I'm going to close it. If anyone is still affected by this, let me know and I'll re-open it.