search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

Custom types in PR aren't respected #104

Closed ivanovaleksandar closed 4 years ago

ivanovaleksandar commented 4 years ago

I have the following .github/semantic.yml file, but the custom types are not being respected in the PR title:

titleOnly: true

types:
- major
- minor
- patch
- feat
- fix
- docs
- ci
- build
- test

Are the custom types only applicable to commits, but not PRs?

zeke commented 4 years ago

Are the custom types only applicable to commits, but not PRs?

I'm not actually sure, as I didn't implement that feature and I don't use any custom types in my projects. You may have to jump into the code here to figure out how it's working. If PR titles are not being supported, I will happily accept a pull request that fixes that.

ivanovaleksandar commented 4 years ago

So after testing once again, I noticed that after merging .github/semantic.yml to master, then every next PR will have the custom types. By default, only the pre-defined ones work, which is a weird behavior.

zeke commented 4 years ago

Ah yes that's expected behavior from Probot:

For security reasons, configuration is only loaded from the repository's default branch, changes made in pull requests from different branches or forks are ignored.

Thanks for following up. 👍🏼

ivanovaleksandar commented 4 years ago

Thank for clearing this up! It is good to be aware that this is the expected behaviour for Probot.