search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

Status not updating when PR title is changed #108

Closed protyposis closed 2 years ago

protyposis commented 4 years ago

Hi,

I am frequently running into the following situation:

  1. new PR is opened, neither title nor commits are semantic, error status is set (red)
  2. PR title changed to be semantic
  3. status is not updated and stays in error status

Expectation: status should update and change to success (green) when the PR title is updated

Is this a bug or am I missing something?

Thanks!

zeke commented 4 years ago

Yeah it's supposed to work this way but I wonder if something regressed recently? I think I saw this happen on a PR the other day. Do you have a public example somewhere?

protyposis commented 4 years ago

I was evaluating your bot in a private repo so unfortunately there's no public example, I could however reliably reproduce this in every PR.

janpio commented 4 years ago

Possibly related: https://github.com/zeke/semantic-pull-requests/issues/112 (with public example)

protyposis commented 4 years ago

Yep the public example posted above perfectly demonstrates the problem.

janpio commented 4 years ago

In https://github.com/zeke/semantic-pull-requests/issues/112#issuecomment-680884075 I showed that this also happen when you open the PR with a semantic PR title already - the bot is still unhappy, not only when the PR is only renamed to have a semantic title.

zeke commented 3 years ago

I need help! https://github.com/zeke/semantic-pull-requests/issues/150

zeke commented 2 years ago

This issue is old and inactive so I'm going to close it. If anyone is still affected by this, let me know and I'll re-open it.