search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

Custom types commit title seems to fail #110

Closed Clumsy-Coder closed 4 years ago

Clumsy-Coder commented 4 years ago

Using custom types seems to fail semantic-pull-requests checks

ex: commit title

refactoring(semantic-release): ♻️ comment out property 'emoji' and 'code'

.github/semantic.yml

types:
  - feat
  - fix
  - docs
  - style
  - refactor
  - perf
  - test
  - build
  - ci
  - chore
  - revert
  - style
  - perf
  - prune
  - fix
  - quickfix
  - feature
  - docs
  - deploy
  - ui
  - init
  - test
  - security
  - osx
  - linux
  - windows
  - android
  - ios
  - release
  - lint
  - wip
  - fix-ci
  - downgrade
  - upgrade
  - pushpin
  - ci
  - analytics
  - refactoring
  - docker
  - dep-add
  - dep-rm
  - config
  - i18n
  - typo
  - poo
  - revert
  - merge
  - dep-up
  - compat
  - mv
  - license
  - breaking
  - assets
  - review
  - access
  - docs-code
  - beer
  - texts
  - db
  - log-add
  - log-rm
  - contrib-add
  - ux
  - arch
  - iphone
  - clown-face
  - egg
  - see-no-evil
  - camera-flash
  - experiment
  - seo
  - k8s
  - types
  - seed
  - flags
  - animation
zeke commented 4 years ago

I think you may also need to specify valid scopes in your config:

scopes:
  - semantic-release

Please let me know if that works.

Clumsy-Coder commented 4 years ago

Is there a way to use it without defining scopes?

Or is there a way to accept any scope?

zeke commented 4 years ago

Is there a way to use it without defining scopes?

Using a commit without a scope e.g. refactoring: comment out property should work, or you can define the allowed scopes in your config. I'm going close this issue since this is expected behavior and not actually a bug.

Or is there a way to accept any scope?

No, but if you want that functionality I'd consider accepting a pull request that adds support for it. 👍🏼