search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

enhance title check #131

Closed millievn closed 1 year ago

millievn commented 3 years ago

when make a pr with semantic title , it checks and pass through. But if i edit the title without changing code, it doesn't check again.

Please do something to make it work.

smasala commented 3 years ago

Yes, same issue. Doesn't trigger on title change. Tried setting the PR to draft and back again (didn't trigger it either). Only workaround was to push another commit

smasala commented 3 years ago

Closing and opening the PR again works (not creating a new PR).

slaven3kopic commented 3 years ago

Same here. Any news about this?

zeke commented 3 years ago

Sorry to hear it's not working. I'm not able to investigate right now but if you can open a PR with a failing test the reproduces the issue that would be very helpful.

stefancplace commented 3 years ago

I have the same problem ...

hippiechick60 commented 3 years ago

Sent from Yahoo Mail on Android

On Mon, May 17, 2021 at 1:25 AM, Stefan @.***> wrote:

I have the same problem ...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

smasala commented 3 years ago

@zeke as requested: https://github.com/zeke/semantic-pull-requests/pull/145 the PR shows that the check doesn't trigger again on title change.

Here is an example on another app and the required event: https://github.com/coleHafner/semantic-pr-title/blob/master/index.js#L15

zeke commented 3 years ago

I need help! https://github.com/zeke/semantic-pull-requests/issues/150

zeke commented 2 years ago

This issue is old and inactive so I'm going to close it. If anyone is still affected by this, let me know and I'll re-open it.

tobiasbueschel commented 2 years ago

Hi @zeke - thanks for your work on this, I really like this semantic-pull-requests as it ties in well with release-please.

Unfortunately, I also still have the same issue => when the PR title wasn't semantic first, it doesn't check again after I fixed the PR title.

Hence, would be great if we could re-open this issue.

zeke commented 2 years ago

Thank for weighing in @tobiasbueschel. I reopened the issue. I don't have time at the moment to work on a fix for this but if you want to work on it I'd be happy to help you test and ship it.