search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

Deploying as new app (for use in GHE), but not processing new PRs #138

Closed ScottChapman closed 3 years ago

ScottChapman commented 3 years ago

So, I've deployed this and given it what appears to be the right permissions and is listening to all PR events. I do see output that suggests that it is getting the event: 

 DEBUG probot: Webhook received
   event: {
     "event": "pull_request.opened",
     "id": "51a5a280-a39b-11eb-9015-c519e05faaec",
     "installation": 3433,
     "repository": "<myrepo>"
   }

But... I don't see anything actually get processed. I threw in some debugging into the handler, and it doesn;t seem like that is getting called.

What might I be missing?

zeke commented 3 years ago

Figured it out? Can you share any details on what resolved your issue?

ScottChapman commented 3 years ago

yea, I suspect that it wasn't properly using my app config. For example, I hadn'y set the APP_ID properly. It seems to be working now.

Any reason you didn't use the significantly more popular https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-commits-parser ?

zeke commented 3 years ago

If there was a reason, I can no longer remember what it was. 🤔

If you think that module has better support and is more actively maintained, and it passes tests on this project, I'd happily accept a pull request to use it.

ScottChapman commented 3 years ago

ha, yea. Let em noodle on it and see if I can do a drop in replacement.

ScottChapman commented 3 years ago

@zeke - how do I run the tests exactly? When I run I get a lot of missing nocks.

zeke commented 3 years ago

npm install and npm test should do the trick. If you're still stuck, can open a new issue for this and ping me from there?

ScottChapman commented 3 years ago

Yea, that's what I was doing. let me open a new issue for it