Empty space prefixing PR title should make the pr title invalid

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning

https://github.com/apps/semantic-pull-requests

Apache License 2.0

1.24k stars 122 forks source link

Empty space prefixing PR title should make the pr title invalid #149

Closed skimi closed 2 years ago

skimi commented 3 years ago

I've just stumbled onto this one:

Have a PR with a valid conventional title but prefixed with a space
```
fix: my broken feature
```
The bot will show ready to be squashed

This is an issue because the conventional-commits lib won't recognise the commit. So, we thought the commit was correct but then the changelog and version numbering did not follow

zeke commented 3 years ago

I need help! https://github.com/zeke/semantic-pull-requests/issues/150

zeke commented 2 years ago

This issue is old and inactive so I'm going to close it. If anyone is still affected by this, let me know and I'll re-open it.