search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

feat: add enabled option #156

Closed ellisio closed 3 years ago

ellisio commented 3 years ago

Our organization allows engineers to create microservices using Spotify's Backstage developer portal. All of these services follow conventional commits. However, we have some repositories in our organization (Helm Charts) that use other release strategies.

We don't want to have to switch to manually adding a newly created service to this configuration every time someone creates a new microservice from Backstage. Instead, we'd rather "opt out" of this merge check on a per-repo basis.

This adds the enabled configuration option, which defaults to true to avoid breaking changes. This would allow organizations in our situation the ability to set enabled: false in .github/semantic.yml to disable this merge check.

ellisio commented 3 years ago

@zeke Can we please get some feedback on this? 🍻

ellisio commented 3 years ago

@zeke Hey man, better late than never I guess... Been crazy in my world. Anywho, just pushed up new commit with the simplified approach.