search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

Is it a issue? When there is no space after colon, PR is invalid #166

Closed elfisworking closed 2 years ago

elfisworking commented 2 years ago

When there is no space after the colon, it is recognized as invalid PR. for example: PR tille

fix:solve function load error

semantic-pull-requests returns false

zeke commented 2 years ago

Yeah the space is required. From the Conventional Commits spec:

Commits MUST be prefixed with a type, which consists of a noun, feat, fix, etc., followed by the OPTIONAL scope, OPTIONAL !, and REQUIRED terminal colon and space.

elfisworking commented 2 years ago

thanks!