search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

chore: Bump node version to 18.x #175

Closed tysonkamp closed 2 years ago

tysonkamp commented 2 years ago

Def took the long way 'round to get to 18.

zeke commented 2 years ago

Thanks.

The GitHub Actions workflow file should also be updated to run on on Node 18.

The relevant line is here: https://github.com/zeke/semantic-pull-requests/blob/021ebc531acdbd9fa882acb9371ecf480a65d17b/.github/workflows/ci.yml#L15

We can probably do without the multiple versions and just test on 18.x

tysonkamp commented 2 years ago

G2G ?

zeke commented 2 years ago

Sorry for all the back and forth here. I misread the calendar. Node.js v18 hasn't come out yet. Falling back to v16

zeke commented 2 years ago

Let's try it and see how it goes.

zeke commented 2 years ago

This should be auto-deployed to production within a few minutes. Please give it a try and let me know how it goes. If there are issues we can revert.