search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

feature: support optional scope in type #180

Closed jbergstroem closed 2 years ago

jbergstroem commented 2 years ago

Types supports an optional scope: https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-scope

My use case is for the bot to be ok with the renovatebot default configuration (chore(deps):).

zeke commented 2 years ago

I thought scopes were already supported? But maybe not. I would happily support a PR for this if you have time to work on it and add tests.

jbergstroem commented 2 years ago

I thought scopes were already supported? But maybe not.

Me too! This PR title fails for me: chore(deps): all non-major dependencies:

Screen Shot 2022-03-21 at 1 14 34 PM

I would happily support a PR for this if you have time to work on it and add tests.

Sounds good to me.

jbergstroem commented 2 years ago

Edit: I'm stupid - typo in scope list..

zeke commented 2 years ago

No problem! You're not stupid. You're a good open source citizen. Thanks for following up. 👍🏼