fix: implement exception free getConfig

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning

https://github.com/apps/semantic-pull-requests

Apache License 2.0

1.24k stars 122 forks source link

fix: implement exception free getConfig #40

Closed paszkowskiDamian closed 4 years ago

paszkowskiDamian commented 5 years ago

This PR introduces a getConfigOrDefault function that will handle all exception thrown by getConfig which only handles cases where API responds with 404.

https://github.com/probot/semantic-pull-requests/issues/38

paszkowskiDamian commented 5 years ago

Of course, I can remove it. The codebase is not so big so it would be really easy to migrate it to Typescript. I don't really like JSCoc because I find it more troublesome to maintain.

zeke commented 4 years ago

Hey @paszkowskiDamian this PR is pretty old now and has some conflicts, so I'm going to close it out. If you wish to revisit it I will happily review it again. Thanks.