search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

titleOnly option is being ignored? #70

Closed coleHafner closed 2 years ago

coleHafner commented 5 years ago

I have a PR with an invalid PR title and the titleOnly: true option in my .github/semantic.yml file. I still get the status "ready to be merged or rebased". It doesn't seem to matter what I do, this will always be the status. The PR does have many commits that meet the conventional commit standard, but those should be ignored per the titleOnly option, right?

Screen Shot 2019-09-15 at 2 20 39 PM

Config file:

Screen Shot 2019-09-15 at 2 24 10 PM

This repo is a private one within an org, so I'm not sure if that has anything to do with it. I know it has been an issue with other apps I've tried.

coleHafner commented 5 years ago

This is still an issue, but I found a different solution. I'm closing it for now.

zeke commented 5 years ago

Hi. What was your different solution?

zeke commented 5 years ago

Re-opening this so we can fix it, regardless of the workaround you found.

coleHafner commented 5 years ago

@zeke Yours is the third app I've tried to find a solution, but none of them seem to work as advertised. I suspect it has something to do with our private repo within our organization.

I created an app that meets my requirements (mostly out of curiosity of how to create a GitHub App). It seems to be working fine for our team.

zeke commented 5 years ago

Thanks for the info.

titleOnly support was added in https://github.com/probot/semantic-pull-requests/pull/30. Hey @guyfedwards are you using this feature successfully?

guyfedwards commented 5 years ago

Yep this works perfectly for our usecase!

zeke commented 5 years ago

@guyfedwards is your repo public or private?

guyfedwards commented 5 years ago

Open source https://github.com/guyfedwards/emojo. Not much activity on it for a while but you can see some failed PRs

GitHub
guyfedwards/emojo
Automatically resize emoji and upload from slack. Contribute to guyfedwards/emojo development by creating an account on GitHub.
mrchief commented 4 years ago

Came here to report the same thing. Can someone pin the solution/workaround?

jayithiel commented 3 years ago

titleOnly is being ignored for me as well. It also checks the commit if there is only 1 commit

don-hover commented 3 years ago

@zeke Please see: https://github.com/zeke/semantic-pull-requests/pull/105#issuecomment-785975869

zeke commented 2 years ago

This issue is old and inactive so I'm going to close it. If anyone is still affected by this, let me know and I'll re-open it.