search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

improvement: add .nvmrc #81

Closed rarneson closed 4 years ago

rarneson commented 4 years ago

Adding a .nvmrc should make it clear to future contributors what version of node to run.

I also took this opportunity to bump a couple deps that were responsible for 1 high and 1 critical vulnerabilities.

zeke commented 4 years ago

Thanks for the contribution, @rarneson. I will go ahead and merge this for the benefit of nvm users, but there is no real convention around this, as other Node versions managers use files like .node-version instead of .nvmrc.

Moving forward, I think a good generic solution that doesn't care how Node.js is installed would be to use something like https://github.com/marcbachmann/assert-node-version, which throws an error if the node version doesn't match the range value of engines.node in package.json.