search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

commitsOnly being ignored #88

Closed baconjulie closed 2 years ago

baconjulie commented 4 years ago

Similar issue to #70 when setting commitsOnly: true in a .github/semantic.yml the check incorrectly passes so long as the PR title is semantic. This is in a private repo.

File change:

Screen Shot 2020-04-20 at 11 20 13 AM

Semantic title, non-semantic commit Screen Shot 2020-04-20 at 11 19 13 AM

Passes check when it should not Screen Shot 2020-04-20 at 11 18 57 AM

sapkra commented 3 years ago

@baconjulie Were you able to find a solution for it? To me it seems like that the script is unable to load the semantic.yml. I have the same problem with titleAndCommits and several other people are reporting the same issue with different options.

zeke commented 3 years ago

Hi folks. Apologies for the long silence.

I do not currently have the time to make the fix myself, but if this is indeed a regression I will happily review/ship/deploy a pull request that addresses the issue. If anyone ends up opening a PR, please ping me @zeke directly so the notification doesn't fall through the cracks of my many hundreds of repos 🙀

Thanks for understanding!

zeke commented 2 years ago

This issue is old and inactive so I'm going to close it. If anyone is still affected by this, let me know and I'll re-open it.