search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

Revert "build(deps): upgrade conventional-commit-types to v3.0.0" #96

Closed zeke closed 4 years ago

zeke commented 4 years ago

Reverts zeke/semantic-pull-requests#94

Not sure what this PR broke, but I'm pretty sure it broke something.

cc @codebytere

cc @felipecassiors

felipecrs commented 4 years ago

I see .travis.yml at the root of the repo, but I can't see any log. Is it private?

zeke commented 4 years ago

I didn't notice the tests had stopped running. That must have been when I migrated this repo from the @probot org to my @zeke account.

I just landed https://github.com/zeke/semantic-pull-requests/pull/97 to migration from Travis to Actions. If you'd like to open a followup PR and try again, that would be helpful. I would suggest maybe just updating the one conventional-commit-types dependency to avoid breaking things unexpectedly. If you could also look into the breaking change between v2 and v3 of that package, that would be helpful.

Thanks!

felipecrs commented 4 years ago

@zeke https://github.com/commitizen/conventional-commit-types/compare/v2.3.0...v3.0.0

zeke commented 4 years ago

Huh. So it was probably some other dep update in #94 that broke the build.