search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

build(deps): upgrade conventional-commit-types to v3.0.0 #98

Closed felipecrs closed 4 years ago

felipecrs commented 4 years ago

It dropped improvements type.

Changelog: https://github.com/commitizen/conventional-commit-types/compare/v2.3.0...v3.0.0

Follow-up: https://github.com/zeke/semantic-pull-requests/pull/94 https://github.com/zeke/semantic-pull-requests/pull/96

felipecrs commented 4 years ago

The tests didn't run. 😥

felipecrs commented 4 years ago

Now they run! 😀

felipecrs commented 4 years ago

@zeke how about the last commit? I took from here: https://github.com/actions/starter-workflows/blob/master/ci/node.js.yml

zeke commented 4 years ago

Let's try it again! 🤞

felipecrs commented 4 years ago

@zeke but the way you did, we lose tests on pull requests.

zeke commented 4 years ago

on: push should run the action for all pushes, whether they're in a PR or not, right?

felipecrs commented 4 years ago

Not really. The on: push runs on every push for every branch in your repository (if it is a fork, it doesn't run).

The on: pull_request runs on every pull request despite it is from a fork or not, and also post the status in the Pull Request checks.