zekeriyasari / Causal.jl

Causal.jl - A modeling and simulation framework adopting causal modeling approach.
https://zekeriyasari.github.io/Causal.jl/dev/
Other
115 stars 7 forks source link

StepGenerator not implemented correctly #34

Closed ValentinKaisermayer closed 4 years ago

ValentinKaisermayer commented 4 years ago

https://github.com/zekeriyasari/Jusdl.jl/blob/bb92c32a40848959b208913cdf3430612dec1a5f/src/components/sources/generators.jl#L237

This does not implement what the doc string says. amplitude is not used.

zekeriyasari commented 4 years ago

Fixed it. Thanks