search

zekroTJA / shinpuru

シンプル - Discord Bot with role selection, moderation, karma ranking, a starboard, code execution, raid alerting, backups, a web interface, twitch notifications and more!
https://shnp.de
MIT License
190 stars 37 forks source link

Banning Member that is no longer on the Guild results in Exception #378

Closed Kaktushose closed 2 years ago

Kaktushose commented 2 years ago

Type

Breaking Issue

Instance

Main Stable (shinpuru#4878 / shnp.de)

Description

When banning a member that is no longer on the Guild, e.g. he left, the ban command fails and throws an exception.

image

Expected behavior would be that the member gets banned nonetheless, using the user object

Steps to reproduce

  1. type ban command for member
  2. member leaves
  3. execute command

Attachments

No response

zekroTJA commented 2 years ago

That's a really interesting use case actually. Anonymous reports are possible at the moment only via the web interface, but actually, it would also be nice to make it possible via the slash command interface. 🤔

Kaktushose commented 2 years ago

I mean just ban the User instead of the Member and this edge case is covered

zekroTJA commented 2 years ago

I mean just ban the User instead of the Member and this edge case is covered

I know what you mean and yes, thats the fix I've implemented for now. But also it would be nice if you could do anonymous bans using slash commands instead of being able to do it only in the web interface.