search

zekroTJA / shinpuru

シンプル - Discord Bot with role selection, moderation, karma ranking, a starboard, code execution, raid alerting, backups, a web interface, twitch notifications and more!
https://shnp.de
MIT License
184 stars 37 forks source link

German i18n overwork #422

Closed voxain closed 1 year ago

voxain commented 1 year ago

Migrate de-DE to "Du"-Form and fix formalities

voxain commented 1 year ago

This commit also converts certain terminology to "Hochdeutsch" in order to keep it in line with what the Discord client uses.

zekroTJA commented 1 year ago

Thank you very much for your contribution. I'll look into it as soon as I find the time to do so. <3

Would you be so kind to rebase your changes onto the dev branch? Therefore the history won't mess up when merging back to master in the next release later on. :)

zekroTJA commented 1 year ago

As you are working on this PR, I've converted it to draft for clarification. When you are ready to submit your changes, feel free to set it to "ready for review" so I can merge it. But don't feel hesitated, It'll take some time until I'll make a new release. ^^

voxain commented 1 year ago

Yes, thank you! I didn't think I'd be working so much on the translation myself, but it turned out to be more than I expected myself to do ^^ I'll let you know when I have everything done - it's not much left :)

zekroTJA commented 1 year ago

Thank you very much for that. I really appreciate it. <3

voxain commented 1 year ago

Thank you for the suggestions @Zoriot - After not so successfully figuring out how GitHub handles these things, I have already applied the changes that I think make perfect sense. Even though I personally still think that "Das Token" is the more german way to go than "Der Token" :D

On the other suggestions, I've left comments on why I left them open, and I'll leave the rest of them to @zekroTJA to decide what to do with them <3

lus commented 1 year ago

@voxain "Der Token" sounds much better imo.

voxain commented 1 year ago

@lus Maybe it sounds like that, which personally I don't think, but the only reason that it's been added as "Der" in the official dictionaries is that people just generally thought it sounded better... If you look it up, most dictionaries still put "das" as the first option becasuse it's been the factually correct way for a long time :)

lus commented 1 year ago

Well, if it was added to dictionaries because it sounds better, it's a win win, isn't it?

voxain commented 1 year ago

I was going for the factually correct Hochdeutsch in the translation, but if more people want to go for this version, it's not my decision.