search

zekyll / OMPEval

Fast C++ poker hand evaluator and equity calculator
ISC License
173 stars 69 forks source link

Max 9 players support #24

Open vkresch opened 3 years ago

vkresch commented 3 years ago

Is it possible to have a 9 players support? I'm currently not sure why but I get a segmentation fault when I just change the constant from 6 to 9 here. Any further pointers would be appreciated! Thanks!

ChrisZevenbergen commented 3 years ago

There's a parameter static const unsigned MAX_PLAYERS in Constants.h. Change it to 9 and you're good to go.

chaines commented 3 years ago

There's a parameter static const unsigned MAX_PLAYERS in Constants.h. Change it to 9 and you're good to go.

I get a segmentation fault when I just change the constant from 6 to 9 here.

vkresch commented 3 years ago

@ChrisZevenbergen that's what I already tried and I get a seg fault.

liuqijie6 commented 2 years ago

Did you solve it please? I happened to have this problem too.

liuqijie6 commented 2 years ago

@ChrisZevenbergen这就是我已经尝试过的，我得到了一段错误。

Did you solve it please? I happened to have this problem too

shackra commented 1 year ago

if you are getting a seg fault when running the tests, is because of this unit test:

    TTEST_CASE("start() returns false when too many players")
    {
        TTEST_EQUAL(eq.start({"AA", "KK", "QQ", "JJ", "TT", "99", "88"}), false);
    }

are more hands (more than 9) and you should get false this time.