search

zeldadungeon / maps

Interactive maps for Zelda games
40 stars 18 forks source link

Give extra vertical space to search result if it contains multiple linebreaks #114

Open Thortok opened 1 year ago

Thortok commented 1 year ago

As a way to make sure the right pin can be found if someone searches by quest name I included linebreaks in its name.

If it's the only search result it doesn't look too bad but if it shows up in a list with others then it does.

image

So far this is only done when quests are available simultaneously (and not sequentially) from the exact same questgiver/location. Sequential quests are stacked instead and given separate pins.

So far there's only 3 places this is done:

https://www.zeldadungeon.net/maps-beta/totk/?z=6&x=3144&y=367&l=Surface&m=SA-InvestigatetheThyphloRuins https://www.zeldadungeon.net/maps-beta/totk/?z=6&x=-2157&y=3646&l=Surface&m=SA-Presenting https://www.zeldadungeon.net/maps-beta/totk/?z=6&x=84&y=-285&l=Surface&m=SQ-WANTED

LockeExile commented 1 year ago

I think these should be given separate stacked markers too, with maplinks to the other ones that can be done in parallel.

Thortok commented 1 year ago

Then how do you decide which one appears by default? It's been a while but I remember people 'reporting' that stuff was 'missing' when we did it that way and it was because one pin was behind another. Sequential stuff didn't have that issue (or had it less often) because as soon as they mark the first complete there's the next. Those work really well actually.

If there was some way to mouseover and have them uncluster, but that'd be a lot of work.