Checklist

[savage13]

Not ready

Added a checklist functionality

• Uses the Tasks pane: spane-dummy
• Markers
  • Copies and modifies image icons by adding a shadowUrl for the check mark / badge
    • For MapGenericLocationMarker
  • For other markers derived MapMarkerCanvasImpl (only Koroks and Location Names)
    • Modifies _updatePath to draw the check mark / badge
    • Required expanding the region defined by _updateBounds to include the badge
• Checklists
  • Lists are stored in Settings under checklists. Each checklist has a name, query and the items in the list (hash_id, name, ui_name, map_name, pos).
  • Marked values are stored directly under checklists by the object's hash_id.
• Context menu
  • Items have an new context menu (Toggle Completed)

Not sure about:

• Storing checklist in the Settings (localStorage)
  • Checklist item storage seems large; would it be better to populate the list when needed (using a query) instead of storing all the items. The checklist does not store if an item is marked.
• Modifying the Korok markers within _updatePath
• Impacts on responsiveness; while developing it does not appear to lag

[leoetlino]

Haven't done a full review yet, but don't use the dummy pane, add a new one

[savage13]

Very close with this.

• Import/Export works.
• Works well with long lists.
• Moved marked / checked values under values
• Items in a checklist are stored as an object for faster access

[savage13]

Closing. Made a mess of the history.