zeldaret / mm

Decompilation of The Legend of Zelda: Majora's Mask
https://zelda.deco.mp/games/mm
1.22k stars 443 forks source link

Document `PLAYER_STATE1_DEAD` #1735

Closed engineer124 closed 2 weeks ago

engineer124 commented 2 weeks ago

RIP 💀

There was a bit of a discussion here on whether this state flag should focus on being in the death cutscene instead i.e. PLAYER_STATE1_IN_DEATH_CUTSCENE. More opinions welcome, but it can always change later though. https://github.com/zeldaret/oot/pull/2204

MM has an additional usage of this flag as well. When Deku/Zora form touches lava, or Goron enters water, this flag is set when resetting the scene. This respawn looks like when Link dies since the death reset is much faster in MM compared to OoT since there isn't a save and quit option. So I think the name is still fine, but also open to thoughts on whether it should affect the name or not