search

zeldaret / oot

Decompilation of The Legend of Zelda: Ocarina of Time
4.56k stars 575 forks source link

Rename gBuildTeam to gBuildCreator #2160

Closed fig02 closed 1 week ago

fig02 commented 1 week ago

Copy/pasting my reasoning from a different PR discussion here:

"We should probably rename gBuildTeam to gBuildCreator at some point. The point is to identify exactly who built the rom, for example zelda@srd44 and zelda@srd022j likely reference individual computer names/users at srd (the team)

this is supported by the ique strings as well, which are non-srd build@toad.routefree.com 03-10-22 16:23:19 username "build" @ hostname "toad.routfree.com" tyu@linuxdev3 06-10-13 14:17:43 username "tyu" @ hostname "linuxdev3" "

also there are multiple prints referring to it as such: Fault_Printf(" [Creator:%s]", gBuildCreator); PRINTF(T("作製者 : %s\n", "Created by: %s\n"), gBuildCreator);

cadmic commented 1 week ago

oops didn't realize I already looked at this