search

zeldaret / oot

Decompilation of The Legend of Zelda: Ocarina of Time
4.56k stars 575 forks source link

fix_bss.py: Restore z_locale special case #2179

Closed cadmic closed 1 week ago

cadmic commented 1 week ago

https://github.com/zeldaret/oot/pull/2169 removed the z_locale special case, but that PR doesn't actually do anything to help z_locale because sCartInfo is in-function static rather than a global symbol. (I didn't catch this in testing because I was running with a list of files rather than no arguments, and didn't notice it complaining about z_locale.c. It does spew a lot of output, maybe we should consider adding a --verbose flag)

fig02 commented 1 week ago

merging without another approval to fix bss check