search

zeldaret / tww

Decompilation of The Legend of Zelda: The Wind Waker
https://zeldaret.github.io/tww
Creative Commons Zero v1.0 Universal
315 stars 47 forks source link

Progress categories support #677

Closed encounter closed 2 months ago

encounter commented 2 months ago

Was using tww as a test-bed for https://github.com/encounter/dtk-template/pull/33

I can revert the changes to the libraries and set them on the individual Objects instead (e.g. Object("foo", progress_category="game")), so let me know.

CI now uses the built-in objdiff report functionality in dtk-template. I assume your website script doesn't care about the report artifact name, but if it does, I can revert that change. (My upcoming progress service does match by artifact name)

LagoLunatic commented 2 months ago

I assume your website script doesn't care about the report artifact name, but if it does, I can revert that change. (My upcoming progress service does match by artifact name)

It does, if you scroll down in build.yml it matches on the name being GZLE01-report-${{ github.sha }}. I included the hash because I thought download-artifact needs you to specify exactly which one to download, but I think I might have misunderstood the documentation?

You can probably remove the -${{ github.sha }} from there too and we can see if it still works.

encounter commented 2 months ago

Don't know how I missed that! Updated. upload/download-artifact are scoped to the current workflow run, so no sha is needed.