search

zeligism / PairedCycleGAN

Automatic makeup generation.
GNU General Public License v3.0
15 stars 1 forks source link

Delauney's triangulation #1

Open LiUzHiAn opened 2 years ago

LiUzHiAn commented 2 years ago

Thanks for your amaaaaaazing work, buddy, really helpful to me. The project design, code base structure and implementation are elegant.

Just a tiny bug there exists is the Delauney's triangulation computing process, see >>here<<. Thought in most cases this would make no effect on the final morphing result, I think it's more reasonable to be h, w, _ = np.array(img).shape.

zeligism commented 2 years ago

Thanks for your nice words, and thanks for pointing out the bug. I used PyTorch’s convention by mistake. Will fix it soon.

LiUzHiAn commented 2 years ago

I just ran the unit test of the the face_morph.py.

When I tried to save the morphing video into .mp4 file, I was told ValueError: unknown file extension: .mp4. So I saved the video in .gif extension instead. But the gif quality is low, do you have any ideas?

Thx.

LiUzHiAn commented 2 years ago

It turns out that opencv works well. Let me PR to fix the tiny mistake and add this video saving feature.

: )