zellij-org / zellij

A terminal workspace with batteries included
https://zellij.dev
MIT License
21.29k stars 645 forks source link

No highlighting of the current selection in the session manager #2747

Open yoav-lavi opened 1 year ago

yoav-lavi commented 1 year ago

Hey!

The new session manager is awesome, but I don't seem to get highlighting for the current selection (which makes navigating difficult).

Screenshot 2023-08-29 at 11 45 27

My theme is the following:

        themes.tokyo-night = {
          fg = "#a9b1d6";
          bg = "#1a1b26";
          black = "#414868";
          red = "#f7768e";
          green = "#73daca";
          yellow = "#e0af68";
          blue = "#7aa2f7";
          magenta = "#bb9af7";
          cyan = "#7dcfff";
          white = "#c0caf5";
          orange = "#ff9e64";
        };

I'm using WezTerm with the wezterm .terminfo

Basic information

zellij --version: zellij 0.38.0 uname -av or ver(Windows): Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 arm64 arm Darwin

yoav-lavi commented 1 year ago

As a side note, might be also interesting for the fuzzy search to include parents of entries. e.g.: If a tab is called cli, is in directory xyz and is running hx, hx cli to find that pane would be useful (even though the specific command does not include cli)

imsnif commented 1 year ago

Hey @yoav-lavi - the theme uses the bg color in the theme, and I guess you're not seeing it because your terminal background is the same color. I'm sorry for the confusion, I realize the naming here is not ideal!

yoav-lavi commented 1 year ago

@imsnif No worries! Although changing the colors for either bg or fg doesn't seem to solve the issue

imsnif commented 1 year ago

If you change the other colors are they updated in the session manager?

yoav-lavi commented 1 year ago

Weirdly no, might be something with nix. I'll retry it sometime soon and update

jscarrott commented 1 year ago

I also have this issue and tried changing the bg and fg colours with no effect.

However, if I change the underlying terminal theme I can see the background colour. Maybe the plugin isn't reloading the config for some reason?

Either way, I think it is very common that people will have the same theme for zellij and their terminal so not sure if using the bg colour is the best choice.

jscarrott commented 1 year ago

I found the source of the bg colour not updating for me - #2768

yoav-lavi commented 1 year ago

@jscarrott looks like that's my issue as well, I'm using tokyo-night and had it manually defined

mahume commented 1 year ago

Same issue with Nord

themes {
    nord {
        fg "#D8DEE9"
        bg "#2E3440"
        black "#3B4252"
        red "#BF616A"
        green "#A3BE8C"
        yellow "#EBCB8B"
        blue "#81A1C1"
        magenta "#B48EAD"
        cyan "#88C0D0"
        white "#E5E9F0"
        orange "#D08770"
    }
}