zellij-org / zellij

A terminal workspace with batteries included
https://zellij.dev
MIT License
21.32k stars 646 forks source link

Nushell issue buffer clear #3297

Open PitiBouchon opened 6 months ago

PitiBouchon commented 6 months ago

Graphical issue inside a terminal

Basic information

zellij --version: zellij 0.40.0

stty size: 29 134

os : Ubuntu 22

Reproductibility

Using nushell inside zellij. I tried using the gnome terminal, alacritty, fish and it's the same problem every time.

Issues with the Zellij UI / behavior

zellij_nushell_issue.webm

Issue description

The buffer is cleared after a command, I can briefly see the result of a ls command but then it gets cleared if the prompt is not at the bottom of the terminal

In the logs I can see:

WARN   |zellij_server::panes::gri| 2024-04-24 13:48:45.996 [screen    ] [zellij-server-0.40.0/src/panes/grid.rs:2436]: Unhandled osc: [[49, 51, 51], [65]] 
WARN   |zellij_server::panes::gri| 2024-04-24 13:48:45.996 [screen    ] [zellij-server-0.40.0/src/panes/grid.rs:3074]: Unhandled esc_dispatch: 92->[] 

which may be the issue

PitiBouchon commented 1 month ago

I think this is fixed on the main branch however

lizclipse commented 6 days ago

I've tried using the current main (eb4b7fc1072e) to see if I could have a try with the kitty keyboard protocol support, and I found that having use_kitty_protocol: true in the nushell config set causes this. Disabling this option fixes it, but it's not a good sign, especially since I did this to try out that support.

This is running in WezTerm nightly (excuse the moral supports in the corners):

https://github.com/user-attachments/assets/5b3b234a-3d13-4f4f-8213-fa5df471ed27

zellij-12.log zellij.log

lizclipse commented 5 days ago

Whoops, looks like I wasnt paying enough attention and did the install command wrong. This is definitely no longer an issue on main, and I think it's because the kitty support is working fine. The rest of it is right, it was the kitty protocol breaking things, tho.

imsnif commented 1 day ago

Wait - so... just to be sure: is this fixed? I'm doing a go-over on major issues before the release and was just circling back to this. I definitely do not want to release something that will break nushell!

PitiBouchon commented 1 day ago

Wait - so... just to be sure: is this fixed? I'm doing a go-over on major issues before the release and was just circling back to this. I definitely do not want to release something that will break nushell!

I just tested on the main branch and there is no issue in nushell for me

lizclipse commented 23 hours ago

To double confirm - I've been running a master build for maybe a week now (since I did it right) with the kitty KB protocol enabled in both and it's been working brilliantly.