search

zellij-org / zellij

A terminal workspace with batteries included
https://zellij.dev
MIT License
21.43k stars 650 forks source link

The `zellij action rename-tab` command results in empty tab in zellij 0.40.0 #3311

Closed tbjers closed 6 months ago

tbjers commented 6 months ago

Issue description

When using zellij action rename-tab the tab name becomes blank.

Minimal reproduction

  1. Start zellij with no configuration
  2. execute zellij action rename-tab "test"

As indicated, the tab name is now empty.

asciicast

Other relevant information

Basic information

zellij --version: 0.40.0

stty size: 44 182

uname -av: Linux bluefin.localhost 6.8.7-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Wed Apr 17 19:35:11 UTC 2024 x86_64 GNU/Linux

/tmp/zellij-1000/zellij-zellij-log/zellij.log

INFO   |zellij_client            | 2024-04-28 10:56:57.196 [main      ] [zellij-client/src/lib.rs:178]: Starting Zellij client! 
INFO   |zellij_server            | 2024-04-28 10:56:57.201 [main      ] [zellij-server/src/lib.rs:281]: Starting Zellij server! 
INFO   |zellij_server            | 2024-04-28 10:56:57.202 [main      ] [zellij-server/src/lib.rs:1058]: Compiling plugins using Cranelift 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1025]: Server not ready, trying to place instruction in retry queue... 
INFO   |zellij_server::plugins   | 2024-04-28 10:56:57.203 [wasm      ] [zellij-server/src/plugins/mod.rs:200]: Wasm main thread starts 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1126]: Server ready, retrying sending instruction. 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1025]: Server not ready, trying to place instruction in retry queue... 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1034]: Server not ready, trying to place instruction in retry queue... 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1126]: Server ready, retrying sending instruction. 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1034]: Server not ready, trying to place instruction in retry queue... 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1045]: Server not ready, trying to place instruction in retry queue... 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1126]: Server ready, retrying sending instruction. 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1045]: Server not ready, trying to place instruction in retry queue... 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1056]: Server not ready, trying to place instruction in retry queue... 
WARN   |zellij_server::route     | 2024-04-28 10:56:57.203 [server_router] [zellij-server/src/route.rs:1126]: Server ready, retrying sending instruction. 
WARN   |zellij_utils::input::layo| 2024-04-28 10:56:57.203 [wasm      ] [zellij-utils/src/input/layout.rs:105]: Overriding plugin alias 
WARN   |zellij_utils::input::layo| 2024-04-28 10:56:57.203 [wasm      ] [zellij-utils/src/input/layout.rs:105]: Overriding plugin alias 
INFO   |zellij_server::plugins::p| 2024-04-28 10:56:57.212 [async-std/runti] [zellij-server/src/plugins/plugin_loader.rs:518]: Loaded plugin 'tab-bar' from cache folder at '/var/home/tbjers/.cache/zellij' in 5.02367ms 
INFO   |zellij_server            | 2024-04-28 10:56:57.212 [async-std/runti] [zellij-server/src/lib.rs:1058]: Compiling plugins using Cranelift 
INFO   |zellij_server::plugins::p| 2024-04-28 10:56:57.218 [async-std/runti] [zellij-server/src/plugins/plugin_loader.rs:518]: Loaded plugin 'status-bar' from cache folder at '/var/home/tbjers/.cache/zellij' in 11.256211ms 
INFO   |zellij_server            | 2024-04-28 10:56:57.218 [async-std/runti] [zellij-server/src/lib.rs:1058]: Compiling plugins using Cranelift 
INFO   |zellij_server::plugins   | 2024-04-28 10:57:11.906 [wasm      ] [zellij-server/src/plugins/mod.rs:734]: wasm main thread exits 
INFO   |zellij_client            | 2024-04-28 10:57:11.906 [main      ] [zellij-client/src/lib.rs:533]: Bye from Zellij! 
ERROR  |zellij_server::os_input_o| 2024-04-28 10:57:11.906 [screen    ] [zellij-server/src/os_input_output.rs:904]: Failed to cache resizes: failed to send message to pty writer 
INFO   |zellij_server::plugins::w| 2024-04-28 10:57:11.906 [wasm      ] [zellij-server/src/plugins/wasm_bridge.rs:282]: Bye from plugin 1 
INFO   |zellij_server::plugins::w| 2024-04-28 10:57:11.906 [wasm      ] [zellij-server/src/plugins/wasm_bridge.rs:282]: Bye from plugin 0 
ERROR  |zellij_server::os_input_o| 2024-04-28 10:57:11.908 [screen    ] [zellij-server/src/os_input_output.rs:915]: Failed to apply cached resizes: failed to send message to pty writer 
ERROR  |zellij_utils::errors::not| 2024-04-28 10:57:11.908 [screen    ] [zellij-utils/src/errors.rs:652]: Panic occured:
             thread: screen
             location: At zellij-server/src/lib.rs:948:18
             message: Program terminates: a fatal error occured

Caused by:
    0: failed to remove client 1
    1: Failed to log and report session state
    2: failed to send message to background jobs
    3: Originating Thread(s)
        1. stdin_handler_thread: AcceptInput
        2. ipc_server: ClientExit
        3. screen_thread: RemoveClient

    4: failed to send message to channel: ReportSessionInfo(
           "outstanding-cuckoo",
           SessionInfo {
               name: "outstanding-cuckoo",
               tabs: [
                   TabInfo {
                       position: 0,
                       name: "",
                       active: false,
                       panes_to_hide: 0,
                       is_fullscreen_active: false,
                       is_sync_panes_active: false,
                       are_floating_panes_visible: false,
                       other_focused_clients: [],
                       active_swap_layout_name: None,
                       is_swap_layout_dirty: false,
                   },
               ],
               panes: PaneManifest {
                   panes: {
                       0: [
                           PaneInfo {
                               id: 0,
                               is_plugin: false,
                               is_focused: true,
                               is_fullscreen: false,
                               is_floating: false,
                               is_suppressed: false,
                               title: "tbjers@bluefin:~/.local/share/chezmoi",
                               exited: false,
                               exit_status: None,
                               is_held: false,
                               pane_x: 0,
                               pane_content_x: 1,
                               pane_y: 1,
                               pane_content_y: 2,
                               pane_rows: 41,
                               pane_content_rows: 39,
                               pane_columns: 182,
                               pane_content_columns: 180,
                               cursor_coordinates_in_pane: Some(
                                   (
                                       6,
                                       6,
                                   ),
                               ),
                               terminal_command: None,
                               plugin_url: None,
                               is_selectable: true,
                           },
                           PaneInfo {
                               id: 0,
                               is_plugin: true,
                               is_focused: false,
                               is_fullscreen: false,
                               is_floating: false,
                               is_suppressed: false,
                               title: "tab-bar",
                               exited: false,
                               exit_status: None,
                               is_held: false,
                               pane_x: 0,
                               pane_content_x: 0,
                               pane_y: 0,
                               pane_content_y: 0,
                               pane_rows: 1,
                               pane_content_rows: 1,
                               pane_columns: 182,
                               pane_content_columns: 182,
                               cursor_coordinates_in_pane: None,
                               terminal_command: None,
                               plugin_url: Some(
                                   "tab-bar",
                               ),
                               is_selectable: false,
                           },
                           PaneInfo {
                               id: 1,
                               is_plugin: true,
                               is_focused: false,
                               is_fullscreen: false,
                               is_floating: false,
                               is_suppressed: false,
                               title: "status-bar",
                               exited: false,
                               exit_status: None,
                               is_held: false,
                               pane_x: 0,
                               pane_content_x: 0,
                               pane_y: 42,
                               pane_content_y: 42,
                               pane_rows: 2,
                               pane_content_rows: 2,
                               pane_columns: 182,
                               pane_content_columns: 182,
                               cursor_coordinates_in_pane: None,
                               terminal_command: None,
                               plugin_url: Some(
                                   "status-bar",
                               ),
                               is_selectable: false,
                           },
                       ],
                   },
               },
               connected_clients: 0,
               is_current_session: true,
               available_layouts: [
                   BuiltIn(
                       "default",
                   ),
                   File(
                       "default",
                   ),
                   File(
                       "compact",
                   ),
                   BuiltIn(
                       "compact",
                   ),
                   BuiltIn(
                       "disable-status-bar",
                   ),
                   BuiltIn(
                       "strider",
                   ),
               ],
           },
       )

/tmp/zellij-1000/zellij-zellij-log/zellij-10.log

]0;tbjers@bluefin:~/.local/share/chezmoi]0;tbjers@bluefin:~/.local/share/chezmoi[?2004h
tbjers@bluefin chezmoi on  main [!] 
📦 $ zellij action rename-tab "nope"
[?2004l
]0;tbjers@bluefin:~/.local/share/chezmoi]0;tbjers@bluefin:~/.local/share/chezmoi[?2004h
tbjers@bluefin chezmoi on  main [!] 
📦 $ [?2004l
[?2004h[?2004l
imsnif commented 6 months ago

Apologies for the regression! This is already fixed in main and I hope to release a patch version with it soon: https://github.com/zellij-org/zellij/pull/3295