search

zellij-org / zellij

A terminal workspace with batteries included
https://zellij.dev
MIT License
20.91k stars 639 forks source link

zellij can't build on Linux ppc64 #3378

Open ky438 opened 4 months ago

ky438 commented 4 months ago

zellij doesn't build on linux ppc64le (ubuntu 22.04 LTS)

cargo xtask build fails with:

Running `target/debug/xtask build` thread 'main' panicked at xtask/src/build.rs:85:22: called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: "protoc failed: action.proto: This file contains proto3 optional fields, but --experimental_allow_proto3_optional was not set.\n" }

Trying to 'skip ahead' and cargo build returns some failures in corosensei, which is also unsupported on ppc64le it seems (https://github.com/Amanieu/corosensei/issues/18).

What is it about zellij (and dependencies) that is so coupled to the underlying hardware/ABI? I'm not sure if the bug here is that another architecture needs support, or if zellij shouldn't need to be aware of the underlying arch?

ky438 commented 4 months ago

note, this seems to be a similar failure to https://github.com/zellij-org/zellij/issues/3180

Zykino commented 4 months ago

I don’t like external binaries dependencies since this kind of problem exist because of them. See my feature/compile fork’s branch (specifically this commit for an example on passing arguments to protoc.

ky438 commented 4 months ago

Thanks - that commit fixes this build issue!

On Sun, May 26, 2024 at 02:31:28AM -0700, Zykino wrote:

I don’t like external binaries dependencies since this kind of problem exist because of them. See my feature/compile fork’s branch (specifically this commit for an example on passing arguments to protoc.

-- Reply to this email directly or view it on GitHub: https://github.com/zellij-org/zellij/issues/3378#issuecomment-2132152055 You are receiving this because you authored the thread.

Message ID: @.***>

runlevel5 commented 1 week ago

The dependency on cranelift and its sub-dependencies (such as wasmtime) only makes thing harder to get the software to built for ppc64le.