search

zellij-org / zellij

A terminal workspace with batteries included
https://zellij.dev
MIT License
19.38k stars 610 forks source link

Support hiding session-manager with `Esc` on `New Session` tab #3408

Open cristiand391 opened 3 weeks ago

cristiand391 commented 3 weeks ago

the session-manager supports Esc to hide itself except in New Session tab, I've checked the code don't see it calls hide_self like others handlers do (when it isn't in the welcome screen mode).

new-session handler: https://github.com/zellij-org/zellij/blob/56baf0b13dfc177a095ae9b3267fe531d4453099/default-plugins/session-manager/src/main.rs#L246C1-L249C15

attach-to-session handler: https://github.com/zellij-org/zellij/blob/56baf0b13dfc177a095ae9b3267fe531d4453099/default-plugins/session-manager/src/main.rs#L370C1-L377C19

resurrect-session handler: https://github.com/zellij-org/zellij/blob/56baf0b13dfc177a095ae9b3267fe531d4453099/default-plugins/session-manager/src/main.rs#L423C1-L427C15

Unless this was intentional, it would be nice to have this behavior consistent in all 3 tabs.