fix: use ITU T.418 format for emitted CSI 58 sequences

zellij-org / zellij

A terminal workspace with batteries included

https://zellij.dev

MIT License

19.38k stars 610 forks source link

fix: use ITU T.418 format for emitted CSI 58 sequences #3440

Closed tranzystorekk closed 1 week ago

tranzystorekk commented 1 week ago

Addresses https://github.com/microsoft/terminal/issues/17426 on our side.

Tested both on nightly wezterm on Windows WSL2, and on a native linux wezterm for a cursory regression check.

imsnif commented 1 week ago

Thanks for this! I'm happy to see this issue resolved for the joint users of Zellij and windows terminal.

Just for the record, as specified in the linked issue: I see this as a workaround for an issue in windows terminal. I mean this in the most blameless way possible, but in case we find that this workaround causes issues in other terminals in a way that cannot be consolidated, we'll have to undo it and hope that the windows terminal folks fix the issue on their side in one way or another.