fix(themes): fix text selection color for nightfox

zellij-org / zellij

A terminal workspace with batteries included

https://zellij.dev

MIT License

19.38k stars 610 forks source link

fix(themes): fix text selection color for nightfox #3450

Open avinal opened 1 week ago

avinal commented 1 week ago

Changes

bg is used as text background color for selection instead of the background color of the zellij itself
this non-conventional naming confuses theme contributors and the user sees no highlight on selection
this commit updates the selection color for nightfox theme and adds missing variations of the theme
refer https://github.com/EdenEast/nightfox.nvim/pull/444

Signed-off-by: Avinal Kumar avinal.xlvii@gmail.com

avinal commented 1 week ago

This issue exists in other themes as well. There is a need to check them or change this convention. At least this needs to be documented somewhere so that theme contributors can put the right colors.

giyany commented 1 week ago

Changes to the theme definition are expected at some point, #3242 .