Closed towry closed 4 days ago
Can you help me understand what you are trying to fix? This doesn't seem related to #3421 - but maybe I'm missing something?
I am trying to fix the paste not working in neovim and helix issue, the changes works (build and tested), the changes is related to #3421.
The link in the above related to another issue with plugin, for example, in plugin write_chars
not working any more if kitty keyboard protocol is enabled, unless I change false
to true
in https://github.com/zellij-org/zellij/blob/fa110515aa672ff47b61fd69090da46a3c28d103/zellij-server/src/plugins/zellij_exports.rs#L1065
I appreciate this PR and thank you for it. I hear you that this fixes the issue (and also the issue with the plugin), but I think there might be a different underlying problem (eg. with bracketed paste or the way we serialize keys to the terminal pane when it's operating in a different keyboard mode than the controlling terminal).
I'd rather look more deeply into it and solve the root problem, because what's happening here might just be solving a symptom of it. I fully plan on doing this before the release and will remind everyone that it's better not to use git versions, but rather to use the latest release version.
Thanks for putting this together though.
Fix #3421
Some plugin are using the
write
andwrite_chars
methods but it doesn't take care of the kitty keyboard protocol, see https://github.com/zellij-org/zellij/blob/fa110515aa672ff47b61fd69090da46a3c28d103/zellij-server/src/plugins/zellij_exports.rs#L1065