zellij-org / zellij

A terminal workspace with batteries included
https://zellij.dev
MIT License
21.99k stars 669 forks source link

Crash on MoveFocusRight #3772

Open istankovic opened 1 week ago

istankovic commented 1 week ago

Issue description

I had two panes side-by-side, one of them was fullscreen IIRC. When I tried moving the focus, it crashed with message:

Error occurred in server:

  × Thread 'screen' panicked.
  ├─▶ Originating Thread(s)
  │     1. stdin_handler_thread: AcceptInput
  │     2. screen_thread: MoveFocusRight
  │   
  ├─▶ At zellij-server/src/panes/tiled_panes/mod.rs:1623:73
  ╰─▶ called `Option::unwrap()` on a `None` value
  help: If you are seeing this message, it means that something went wrong.

More info: zellij.log

This is with 0.41.1, inside Konsole.

istankovic commented 1 week ago

Another crash just happened, this time with SpawnTerminalVertically: zellij.log

imsnif commented 1 week ago

Thanks for the report @istankovic and my apologies for the experience.

These are crashes due to races exposed by our recent runtime change. I addressed them in https://github.com/zellij-org/zellij/pull/3776 and hope to release a patch version with these and other fixes soon.

noahfraiture commented 1 week ago

I also have these crash on zellij 0.41.1. It happen when I'm on full panel and try to move to another panel. It's very annoying because it kills my process which can be a big problem in some case