zellij-org / zellij

A terminal workspace with batteries included
https://zellij.dev
MIT License
20.26k stars 630 forks source link

Colors from tokyonight colorsheme makes the UI unreadable and ugly #769

Open gikari opened 2 years ago

gikari commented 2 years ago

When using colors from tokyonight color scheme, the interface becomes very unpleasant and unreadable. In particular Cyan color is very bright and some text elements on it are not readable.

Screenshot: Screenshot_20211006_234919

Config (I transformed the values from the Alacritty config above into RGB):

themes:
  default:
    bg: [36, 40, 59]
    fg: [192, 202, 245]
    black: [29, 32, 47]
    red: [247, 118, 142]
    green: [158, 206, 106]
    yellow: [224, 175, 104]
    blue: [122, 162, 247]
    magenta: [187, 154, 247]
    cyan: [125, 207, 255]
    white: [169, 177, 214]
    orange: [255, 158, 100]

For comparison, there is tmux with the same color scheme: Screenshot_20211006_235041

It is not as colorful, but at least it is readable.

Here is neovim:

Screenshot_20211006_235505

Zellij version: 0.18.1

imsnif commented 2 years ago

I think this should work now (we had a bug with the cyan/gray color). Can you check?

gikari commented 2 years ago

Seems like the cyan is now gray. I don't know what to pick for gray color, but chose [65, 72, 104]. It now looks better, indeed. However, the Ctrl + gpt... keys are still unreadable (see the screenshot):

image

Here is my new config just in case:

themes:
  default:
    bg: [36, 40, 59]
    fg: [192, 202, 245]
    black: [29, 32, 47]
    red: [247, 118, 142]
    green: [158, 206, 106]
    yellow: [224, 175, 104]
    blue: [122, 162, 247]
    magenta: [187, 154, 247]
    cyan: [125, 207, 255]
    white: [169, 177, 214]
    orange: [255, 158, 100]
    gray: [65, 72, 104]

I think the problem is that zellij tries to mix the terminal colors, that can be readable on top of each other or not, depending on color scheme.

Color scheme authors assume, that colors, that are not foreground or background are only used on top of bg color or maybe inside the fg color. Notice, that the lower Hints pane is perfectly readable with orange and green on top of background color, for example, while the Ctrl hits is less readable: oranges are hard to distinguish and the white "Ctrl +" is only readable because the white and gray colors are further apart, than they could (in different color scheme it could be an issue).

cryoteeth commented 2 years ago

This problem to be exclusive to truecolor, so as a workaround you can use numbers 0 to 15 in 265-color, which are defined by the terminal settings?

ForsakenHarmony commented 3 months ago

I think this might be caused by the indexed colors (16, 17), I'm having a similar issue on catppuccin and disabling the indexed colors fixed it (switching to the zellij catppuccin theme also fixes it)

ALizarazoTellez commented 1 month ago

Moderators if this counts as spam, delete it, although I don't mean to.

Folke's version of TokyoNight for Zellij has no such problems: https://github.com/folke/tokyonight.nvim/blob/main/extras/zellij/tokyonight_night.kdl