zellneralex / klipper_config

This is the config of my Voron 2.4 350mm3 Serial:V2.660
GNU General Public License v3.0
348 stars 100 forks source link

A failed QGL in combination with MAG Probe would still run into a issue during prime line #21

Closed Piranha1511 closed 1 year ago

Piranha1511 commented 1 year ago

Even with the latest commit, a failed QGL (e.g. due to a not probably docked probe) would still run into a issue during prime line and before print.

Since the CHECK_QGL will be executed after the prime line!

Result: MAG Probe (e.g. Klicky) can smash into the bed.

zellneralex commented 1 year ago

First off all a mag probe should not be able to smash in the bed. The G0/G1 micro should prevent that. https://github.com/zellneralex/klipper_config/blob/master/magprobe.cfg#L157.

I do not have a better solution! The add of the error code section in [virtual sdcard] may prevent that at all but I had no time yet to test it.

Piranha1511 commented 1 year ago

On my printer it is still a issue if you run a second print. A new QGL will not be performed and QGL is still seen as "true", but a bed mesh was performed before. If the probe is not probably docked after bed mesh, it will smash into the bed.

zellneralex commented 1 year ago

I am not sure what you mean by that, but as I stated it many times. See that config as something you can get ideas.

As you see in my config I do no mesh, if you have a problem there you should work on a solution. But https://github.com/zellneralex/klipper_config/blob/master/probe_qgl.cfg#L111 should detect your docking failure And if your probe would still show docked this would prevent the smashing in the bed https://github.com/zellneralex/klipper_config/blob/master/magprobe.cfg#L168

or does your probe stays “half” on so that it is detected as docked. Then I really recommend to make your docking more reliable as that can not be detected at all.

zellneralex commented 1 year ago

And yes that’s the main problem with all the mag probes. If you can not get it to reliable undock you risk to smash it in the bed. That’s the reason why my macro use an 90 degree angle to avoid that.

That’s also one reason why I will switch to Voron Tap soon.