Init player before incoming message emitted

zelloptt / zello-channel-api

WebSocket-based API and SDKs to connect to Zello channels (BETA)

MIT License

88 stars 35 forks source link

Closed ihorserba closed 2 years ago

ihorserba commented 2 years ago

Added uninit of the player once it was failed.

ihorserba commented 2 years ago

@vocoded please take a look once more

ihorserba commented 2 years ago

Addressed all the comments, updated pcm-player with the it's latest master, increased the major version, rebuilt SDK.

It's ready for another look.

ihorserba commented 2 years ago

Back merged version_1_0_0 to init_player_before_incoming_message_emitted. Rebuilt the SDK in order to resolve the conflicts.

ihorserba commented 2 years ago

@vocoded - just a reminder, I think I addressed all the comments here