zelloptt / zello-channel-api

WebSocket-based API and SDKs to connect to Zello channels (BETA)
MIT License
88 stars 35 forks source link

Version 1.0.0 #184

Closed ihorserba closed 2 years ago

ihorserba commented 2 years ago

Once https://github.com/zelloptt/opus-recorder/pull/7 is re-approved (there were some changes since the last approve) - we have to update the opus-recorder submodule

ihorserba commented 2 years ago

Last fixes for recorder: https://github.com/zelloptt/opus-recorder/pull/9

ihorserba commented 2 years ago

Another small documentation fix https://github.com/zelloptt/opus-to-pcm/pull/2

ihorserba commented 2 years ago

Is 80e753f52562eb454910.worker.js a desired file we actually want to commit? It seems to me like these files are maybe incidental from our build process, and that we don't actually want them?

Yes, it's a desired file. It's requested as blob before sending and before receiving audio data.

Sending an outgoing audio message:

Screenshot 2022-08-05 at 16 11 41

Receiving an incoming audio message:

Screenshot 2022-08-05 at 16 15 04
adambailey- commented 2 years ago

It's requested as blob before sending and before receiving audio data.

What's the significance behind the name of this?

vocoded commented 2 years ago

@adambailey- Nothing we are setting, this is output from emscripten

ihorserba commented 2 years ago

It's requested as blob before sending and before receiving audio data.

What's the significance behind the name of this?

I'm not sure. The filename is generated by webpack.

ihorserba commented 2 years ago

Back-merged master Merged the auth token version support Rebuilt SDK

ihorserba commented 2 years ago

Back-merged master, changed according to the latest minor comments; rebuilt SDK

ihorserba commented 2 years ago

minor. are you still waiting on anything to merge?

I remember the comment here

Maybe add a brief description about possible tokenVersion values?

Or it's supposed not to be used by SDK users yet?

vocoded commented 2 years ago

It can be used, the only supported value is v1 to indicate the current token format. if omitted, this will be the assumed version.