search

zellwk / adaptive-placeholders

Float label pattern built with pure SCSS
129 stars 20 forks source link

Deprecation warning #1

Closed grosch closed 10 years ago

grosch commented 10 years ago

DEPRECATION WARNING on line 47 of .../_adaptive-placeholders.scss: Assigning to global variable "$label-color" by default is deprecated. In future versions of Sass, this will create a new local variable. If you want to assign to the global variable, use "$label-color: map-get($map, label-color) !global" instead. Note that this will be incompatible with Sass 3.2.

zellwk commented 10 years ago

@grosch did you happen to have another variable called $label-color anywhere in your Sass file? I suspect that is what prompted the deprecation warning. Not to worry though, all of these variables are supposed to be local.

grosch commented 10 years ago

I didn't

On Sep 14, 2014, at 5:39 PM, Zell Liew notifications@github.com wrote:

@grosch did you happen to have another variable called $label-color anywhere in your Sass file? I suspect that is what prompted the deprecation warning. Not to worry though, all of these variables are supposed to be local.

— Reply to this email directly or view it on GitHub.

zellwk commented 10 years ago

I'm not able to reproduce the deprecation warning on my side. Are you able to put up a repo that has this error so I can pull and test?

grosch commented 10 years ago

Not even sure where that code is any longer. Just close this out and when I get back to doing web stuff, if it occurs again, I’ll open a new issue.

On Sep 14, 2014, at 7:12 PM, Zell Liew notifications@github.com wrote:

I'm not able to reproduce the deprecation warning on my side. Are you able to put up a repo that has this error so I can pull and test?

— Reply to this email directly or view it on GitHub.

zellwk commented 10 years ago

Okay. Sorry for getting back so late. Let me know again if this pops up