search

zellyn / a2audit

Apple II audit routines: for testing your Apple II or emulator
MIT License
29 stars 6 forks source link

fix unreachable code, add more LC tests #1

Closed peterferrie closed 7 years ago

peterferrie commented 7 years ago

zellyn commented on this pull request.

@@ -29,10 +29,10 @@ LANGCARDTESTS_NO_CHECK: +prerred sec rts

  • lda #$33 -+ sta $FE1F ; FE1F is $60 in Apple II/plus/e/enhanced ++ lda #$33

Oops. Thanks!

@@ -49,6 +49,24 @@ LANGCARDTESTS_NO_CHECK: +prerred sec rts ++ lda $C08B ; Read and write bank 1 with single access (only one needed if banked in already)

FYI, I had a lot of explicit tests here, and tried to move anything but sanity checks down into the data-driven tests below. Would these be better off there?

You're the boss, you get to decide. If your choice match what I have, then close the PR and do it your way. I won't be offended. :-)

peterferrie commented 7 years ago

I mean, "if your choice doesn't match..."